feat: Add more support kinds for data extensions#2415
Closed
GeekMasher wants to merge 1 commit intogithub:mainfrom
Closed
feat: Add more support kinds for data extensions#2415GeekMasher wants to merge 1 commit intogithub:mainfrom
GeekMasher wants to merge 1 commit intogithub:mainfrom
Conversation
aeisenberg
reviewed
May 10, 2023
Comment on lines
+85
to
+94
| supportedKinds: [ | ||
| "command-injection", | ||
| "html-injection", | ||
| "log-injection", | ||
| "response-splitting", | ||
| "path-injection", | ||
| "sql-injection", | ||
| "url-redirection", | ||
| "xpath-injection", | ||
| ], |
Contributor
There was a problem hiding this comment.
In the long term, we should be generating this list directly from the core libraries themselves. But this looks reasonable to me right now. I'll wait for the secexp team to approve this, since they are working on the feature.
Author
There was a problem hiding this comment.
@aeisenberg Makes complete sense and would be amazing to be done automatically.
3 tasks
Contributor
|
Sorry for not merging this sooner. We updated the kinds in #2691 (that included a few additional kinds). So closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated and added a few data extensions sink models. Both Java and CSharp are moving to use the following models in the near future so I think we should be ahead of the curve.
Checklist
ready-for-doc-reviewlabel there.